-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional manifest checks to detect missing CRDs & CRs #5921
Conversation
140f909
to
7ae86fc
Compare
Signed-off-by: Joel Smith <[email protected]>
The check seems to be working. For example: https://github.com/kedacore/keda/actions/runs/9708520106/job/26795477554?pr=5921
So now I need to add another commit to add the missing manifests and references. Edit: commit 2 added and now the new test passes without errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
/run-e2e internal |
Add missing CR references to config/sample/kustomization.yaml Signed-off-by: Joel Smith <[email protected]>
Signed-off-by: Joel Smith <[email protected]>
Sorry for the last-minute change. I just noticed that the sample CR I copied (triggerauthentication) had an API group of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…#5921) Signed-off-by: uucloud <[email protected]>
This PR has three parts:
kustomize.yaml
file and that every CRD also has a sample CR for each of its API versions and is similarly listed in thekustomize.yaml
file for sample CR files.triggerauthentication
which had the old API group ofkeda.k8s.io
instead of the newkeda.sh
Checklist
Fixes #5920