Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new alignment parameters 'rate' and 'count' for GCP Stackdriver Scaler #5634

Merged
merged 1 commit into from
Mar 30, 2024
+5 −0
Merged

feat: Add new alignment parameters 'rate' and 'count' for GCP Stackdriver Scaler #5634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ Here is an overview of all new **experimental** features:
- **General**: Add GRPC Healthchecks ([#5590](https://github.com/kedacore/keda/issues/5590))
- **General**: Add OPENTELEMETRY flag in e2e test YAML ([#5375](https://github.com/kedacore/keda/issues/5375))
- **General**: Add support for cross tenant/cloud authentication when using Azure Workload Identity for TriggerAuthentication ([#5441](https://github.com/kedacore/keda/issues/5441))
- **GCP Stackdriver Scaler**: Add missing parameters 'rate' and 'count' for GCP Stackdriver Scaler alignment ([#5633](https://github.com/kedacore/keda/issues/5633))
- **Metrics API Scaler**: Add support for various formats: json, xml, yaml, prometheus ([#2633](https://github.com/kedacore/keda/issues/2633))
- **MongoDB Scaler**: Add scheme field support srv record ([#5544](https://github.com/kedacore/keda/issues/5544))

Expand Down
4 changes: 4 additions & 0 deletions pkg/scalers/gcp/gcp_stackdriver_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ func alignerFromString(aligner string) (monitoringpb.Aggregation_Aligner, error)
return monitoringpb.Aggregation_ALIGN_NONE, nil
case "delta":
return monitoringpb.Aggregation_ALIGN_DELTA, nil
case "rate":
return monitoringpb.Aggregation_ALIGN_RATE, nil
case "interpolate":
return monitoringpb.Aggregation_ALIGN_INTERPOLATE, nil
case "next_older":
Expand Down Expand Up @@ -195,6 +197,8 @@ func reducerFromString(reducer string) (monitoringpb.Aggregation_Reducer, error)
return monitoringpb.Aggregation_REDUCE_SUM, nil
case "stddev":
return monitoringpb.Aggregation_REDUCE_STDDEV, nil
case "count":
return monitoringpb.Aggregation_REDUCE_COUNT, nil
case "count_true":
return monitoringpb.Aggregation_REDUCE_COUNT_TRUE, nil
case "count_false":
Expand Down
Loading