Fix/ListAllExternalMetrics change to return api-resource types #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 6, 2022 16:46
…ternalMetricsInfo code
Signed-off-by: penghuazhou <penghuazhou@[email protected]>
…ternalMetricsInfo code Signed-off-by: penghuazhou <penghuazhou@[email protected]>
Signed-off-by: penghuazhou <penghuazhou@[email protected]>
penghuazhou
changed the title
Signed-off-by: penghuazhou <penghuazhou@[email protected]>
|
@penghuazhou could you please tell me the rationale behind this change? I don't follow what is the actual improvement here as we don't expose the provided metrics anymore. Aren't those metrics needed then? 🤔 We should have some confirmation from upstream k8s about this. |
|
/run-e2e |
I will get some confirmation from upstream k8s about this. |
7 tasks
|
Any update on this? |
|
This topic is being discussed in the upstream kubernetes-sigs/custom-metrics-apiserver#146 (comment) |
|
Closing this in favor of: #4473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListAllExternalMetrics change to return api-resource types, delete externalMetricsInfo code.
Checklist
Relates to #1797