reword(rabbitmq): make condition match error string #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translated in a sentence, the conditional statement would match "if excludeUnacknowledged is set and the protocol used is equal to amqp" instead of "if excludeUnacknowledged is set and the protocol used is different then http" Signed-off-by: Theo Bob Massard <[email protected]>
tbobm
force-pushed
the
refactor/rabbitmq-scaler-conditional-wording
branch
from
664ed46 to
160bdc4
Compare
|
I have closed/reopened the PR because the CI checks were stuck |
|
/run-e2e rabbit* |
JorTurFer
approved these changes
Oct 10, 2022
zroubalik
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reword a conditional statement in the RabbitMQ Scaler to match the error message that is returned when evaluating to true.
Translated in a sentence, the conditional statement would match "if excludeUnacknowledged is set and the protocol used is equal to amqp" instead of "if excludeUnacknowledged is set and the protocol used is different then http"
Checklist