feat(metrics-api): allow user to configure metrics API server port #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e internal* |
zroubalik
requested changes
Aug 22, 2022
There was a problem hiding this comment.
Looking good, could you please fix the linter problems and fix DCO?
https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what
doctorpangloss
force-pushed
the
main
branch
6 times, most recently
from
55ea0a5 to
2a1c336
Compare
…s://github.com/kedacore/keda/issues/3570) Signed-off-by: Benjamin Berman <[email protected]>
tomkerkhove
changed the title
zroubalik
approved these changes
Aug 23, 2022
|
let's do it with the corresponding chart change let me know if there's anything else I should do, |
|
We're definitely open for PRs on our Helm chart as well - Thank you! Happy you like KEDA - We are always looking for new end-users! |
|
I think we can merge this. We held it before the hotfix release but next we can proceed. @zroubalik ? |
JorTurFer
approved these changes
Sep 14, 2022
|
/run-e2e internal* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to specify which port the metrics API server container should use.
Checklist
Relates to #3576
Relates to kedacore/charts#308