-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to get queueURL from env for aws SQS scaler #3559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you modify the unit tests to include this metadata parameter?
And also raise a documentations PR in kedacore/keda-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Could you solve the DCO issue 🙏 ? We need that all the commits are signed
Add `queueURLFromEnv` as additional trigger metadata to allow loading the queueURL from env variables Signed-off-by: Fahdi Kanavati <[email protected]>
Co-authored-by: Vighnesh Shenoy <[email protected]> Signed-off-by: Fahdi Kanavati <[email protected]>
Signed-off-by: Fahdi Kanavati <[email protected]>
Signed-off-by: Fahdi Kanavati <[email protected]>
Signed-off-by: Fahdi Kanavati <[email protected]>
/run-e2e sqs* |
Thanks for this improvement! ❤️ |
* Add option to get queueURL from env Signed-off-by: Fahdi Kanavati <[email protected]> Co-authored-by: Vighnesh Shenoy <[email protected]> Signed-off-by: 26tanishabanik <[email protected]>
Add
queueURLFromEnv
as additional trigger metadata to allow loading the queueURL from env variables.It would be useful to be able to set the queueURL to load from env variables, especially when having multiple deployment environment. This way if using kustomize, the queueURL could be defined in a configmap and loaded as env variable, rather than patching the manifest. This for example would be similar to the
addressFromEnv
in the redis-lists scaler.Signed-off-by: Fahdi Kanavati [email protected]
Provide a description of what has been changed
Checklist
Fixes #
Relates to #
kedacore/keda-docs#902