feat: Introduce activationThreshold/minMetricValue for Metrics API Scaler

config/crd/bases/keda.sh_clustertriggerauthentications.yaml

@@ -1,10 +1,9 @@
-
 ---
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.6.1
+    controller-gen.kubebuilder.io/version: v0.9.0
   creationTimestamp: null
   name: clustertriggerauthentications.keda.sh
 spec:
@@ -218,9 +217,3 @@ spec:
     served: true
     storage: true
     subresources: {}
-status:
-  acceptedNames:
-    kind: ""
-    plural: ""
-  conditions: []
-  storedVersions: []

config/crd/bases/keda.sh_scaledjobs.yaml

@@ -1,10 +1,9 @@
-
 ---
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.6.1
+    controller-gen.kubebuilder.io/version: v0.9.0
   creationTimestamp: null
   name: scaledjobs.keda.sh
 spec:
@@ -5860,8 +5859,8 @@ spec:
                                     constraint. - DoNotSchedule (default) tells the
                                     scheduler not to schedule it. - ScheduleAnyway
                                     tells the scheduler to schedule the pod in any
-                                    location,   but giving higher precedence to topologies
-                                    that would help reduce the   skew. A constraint
+                                    location, but giving higher precedence to topologies
+                                    that would help reduce the skew. A constraint
                                     is considered "Unsatisfiable" for an incoming
                                     pod if and only if every possible node assignment
                                     for that pod would violate "MaxSkew" on some topology.
@@ -6329,12 +6328,12 @@ spec:
                                     deleted when the pod is removed. \n Use this if:
                                     a) the volume is only needed while the pod runs,
                                     b) features of normal volumes like restoring from
-                                    snapshot or capacity    tracking are needed, c)
-                                    the storage driver is specified through a storage
+                                    snapshot or capacity tracking are needed, c) the
+                                    storage driver is specified through a storage
                                     class, and d) the storage driver supports dynamic
-                                    volume provisioning through    a PersistentVolumeClaim
-                                    (see EphemeralVolumeSource for more    information
-                                    on the connection between this volume type    and
+                                    volume provisioning through a PersistentVolumeClaim
+                                    (see EphemeralVolumeSource for more information
+                                    on the connection between this volume type and
                                     PersistentVolumeClaim). \n Use PersistentVolumeClaim
                                     or one of the vendor-specific APIs for volumes
                                     that persist for longer than the lifecycle of
@@ -6449,13 +6448,13 @@ spec:
                                                 differences between DataSource and
                                                 DataSourceRef: * While DataSource
                                                 only allows two specific types of
-                                                objects, DataSourceRef   allows any
+                                                objects, DataSourceRef allows any
                                                 non-core object, as well as PersistentVolumeClaim
                                                 objects. * While DataSource ignores
                                                 disallowed values (dropping them),
-                                                DataSourceRef   preserves all values,
+                                                DataSourceRef preserves all values,
                                                 and generates an error if a disallowed
-                                                value is   specified. (Alpha) Using
+                                                value is specified. (Alpha) Using
                                                 this field requires the AnyVolumeDataSource
                                                 feature gate to be enabled.'
                                               properties:
@@ -7701,9 +7700,3 @@ spec:
     storage: true
     subresources:
       status: {}
-status:
-  acceptedNames:
-    kind: ""
-    plural: ""
-  conditions: []
-  storedVersions: []

config/crd/bases/keda.sh_scaledobjects.yaml

@@ -1,8 +1,9 @@
+---
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.6.1
+    controller-gen.kubebuilder.io/version: v0.9.0
   creationTimestamp: null
   name: scaledobjects.keda.sh
 spec:
@@ -138,10 +139,9 @@ spec:
                             type: object
                           scaleUp:
                             description: 'scaleUp is scaling policy for scaling Up.
-                              If not set, the default value is the higher of:   *
-                              increase no more than 4 pods per 60 seconds   * double
-                              the number of pods per 60 seconds No stabilization is
-                              used.'
+                              If not set, the default value is the higher of: * increase
+                              no more than 4 pods per 60 seconds * double the number
+                              of pods per 60 seconds No stabilization is used.'
                             properties:
                               policies:
                                 description: policies is a list of potential scaling
@@ -370,9 +370,3 @@ spec:
     storage: true
     subresources:
       status: {}
-status:
-  acceptedNames:
-    kind: ""
-    plural: ""
-  conditions: []
-  storedVersions: []

config/crd/bases/keda.sh_triggerauthentications.yaml

@@ -1,10 +1,9 @@
-
 ---
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.6.1
+    controller-gen.kubebuilder.io/version: v0.9.0
   creationTimestamp: null
   name: triggerauthentications.keda.sh
 spec:
@@ -217,9 +216,3 @@ spec:
     served: true
     storage: true
     subresources: {}
-status:
-  acceptedNames:
-    kind: ""
-    plural: ""
-  conditions: []
-  storedVersions: []

config/rbac/role.yaml

@@ -1,4 +1,3 @@
-
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole

pkg/scalers/metrics_api_scaler.go

@@ -28,9 +28,10 @@ type metricsAPIScaler struct {
 }
 
 type metricsAPIScalerMetadata struct {
-	targetValue   float64
-	url           string
-	valueLocation string
+	targetValue           float64
+	activationTargetValue float64
+	url                   string
+	valueLocation         string
 
 	// apiKeyAuth
 	enableAPIKeyAuth bool
@@ -108,6 +109,15 @@ func parseMetricsAPIMetadata(config *ScalerConfig) (*metricsAPIScalerMetadata, e
 		return nil, fmt.Errorf("no targetValue given in metadata")
 	}
 
+	meta.activationTargetValue = 0
+	if val, ok := config.TriggerMetadata["activationTargetValue"]; ok {
+		activationTargetValue, err := strconv.ParseFloat(val, 64)
+		if err != nil {
+			return nil, fmt.Errorf("targetValue parsing error %s", err.Error())
+		}
+		meta.activationTargetValue = activationTargetValue
+	}
+
 	if val, ok := config.TriggerMetadata["url"]; ok {
 		meta.url = val
 	} else {
@@ -246,7 +256,7 @@ func (s *metricsAPIScaler) IsActive(ctx context.Context) (bool, error) {
 		return false, err
 	}
 
-	return v > 0.0, nil
+	return v > s.metadata.activationTargetValue, nil
 }
 
 // GetMetricSpecForScaling returns the MetricSpec for the Horizontal Pod Autoscaler

pkg/scalers/metrics_api_scaler_test.go

@@ -24,6 +24,8 @@ var testMetricsAPIMetadata = []metricsAPIMetadataTestData{
 	{metadata: map[string]string{"url": "http://dummy:1230/api/v1/", "valueLocation": "metric.test", "targetValue": "42"}, raisesError: false},
 	// Target not an int
 	{metadata: map[string]string{"url": "http://dummy:1230/api/v1/", "valueLocation": "metric", "targetValue": "aa"}, raisesError: true},
+	// Activation target not an int
+	{metadata: map[string]string{"url": "http://dummy:1230/api/v1/", "valueLocation": "metric", "targetValue": "1", "activationTargetValue": "aa"}, raisesError: true},
 	// Missing metric name
 	{metadata: map[string]string{"url": "http://dummy:1230/api/v1/", "targetValue": "aa"}, raisesError: true},
 	// Missing url