Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce activationThreshold/minMetricValue for AWS Scalers #3348

Merged
merged 10 commits into from
Jul 14, 2022
Merged

feat: Introduce activationThreshold/minMetricValue for AWS Scalers #3348

merged 10 commits into from
Jul 14, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jul 10, 2022 •
edited by tomkerkhove
Loading

Signed-off-by: Jorge Turrado [email protected]

Note: Before merging this, we need to merge this other PR and rebase this

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)

Related to kedacore/keda-docs#808
Related to #2800

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 10, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Jul 10, 2022
Merged
1 task
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 10, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

JorTurFer and others added 4 commits July 11, 2022 09:28
@JorTurFer
feat: Introduce activationThreshold/minMetricValue for AWS Scalers
6086593 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Add e2e tests
92ec203 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix identations
e39ea53 
Signed-off-by: Jorge Turrado <[email protected]>
rebase main
0616684 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer force-pushed the activation-threshold-aws branch from 81f2678 to 0616684 Compare July 11, 2022 07:29
fix errors
916410c 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

add missing imports
5d243ac 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

Jorge Turrado and others added 3 commits July 11, 2022 13:36
adjust ShardCount
5663edc 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
increase the random value
81ce8c0 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix test
2ee0f6e 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer marked this pull request as ready for review July 11, 2022 19:57
@JorTurFer JorTurFer requested a review from a team as a code owner July 11, 2022 19:57
@JorTurFer JorTurFer enabled auto-merge (squash) July 11, 2022 19:58
@JorTurFer JorTurFer disabled auto-merge July 11, 2022 19:58
@JorTurFer
fix random number generation
fd0ac48 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 11, 2022 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 4f3cc84 into kedacore:main Jul 14, 2022
@JorTurFer JorTurFer deleted the activation-threshold-aws branch July 14, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @zroubalik