Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add necessary configuration for devcontainer with ARM arch #3085

Merged
merged 3 commits into from
May 30, 2022
Merged

fix: add necessary configuration for devcontainer with ARM arch #3085

merged 3 commits into from
May 30, 2022

Conversation

xoanmm
Copy link
Contributor

@xoanmm xoanmm commented May 30, 2022 •
edited by JorTurFer
Loading

This PR fixes the issue using devcontainers on ARM64 arch and also includes a CI to validate it in the future

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3084

Relates to #

@xoanmm xoanmm requested a review from a team as a code owner May 30, 2022 17:03
@xoanmm xoanmm force-pushed the fix/add-devcontainer-arm branch from 219a444 to 3c69bb9 Compare May 30, 2022 17:04
@xoanmm
fix: correct way of check ARM
f2db864 
Signed-off-by: Xoán Mallón <[email protected]>
@xoanmm xoanmm force-pushed the fix/add-devcontainer-arm branch from d33069e to f2db864 Compare May 30, 2022 17:25
@xoanmm
docs: update CHANGELOG
987785c 
Signed-off-by: Xoán Mallón <[email protected]>
JorTurFer
JorTurFer approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix ❤️

@JorTurFer JorTurFer merged commit 9fab913 into kedacore:main May 30, 2022
@zroubalik
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
ok-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Devcontainer not working for ARM
3 participants
@xoanmm @zroubalik @JorTurFer