Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to make the HTTPClient proxy-aware #2820

Closed
wants to merge 1 commit into from

Conversation

wltbenade
Copy link
Contributor

@wltbenade wltbenade commented Mar 25, 2022

This patch addresses #2577

  • Simple implementation to allow the HTTPClient to read proxy variables, if available, from the environment.
  • Not sure where this should be documented.
  • No tests updated, as all scalers should behave as normal.

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #

@wltbenade wltbenade marked this pull request as ready for review March 25, 2022 10:16
@wltbenade wltbenade requested a review from a team as a code owner March 25, 2022 10:16
@JorTurFer
Copy link
Member

JorTurFer commented Mar 25, 2022

/run-e2e
Update: You can check the progres here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this improvement! ❤️

Let's wait till e2e tests finish. Apart from this, could you create a PR in keda-docs adding information about this? Maybe in the section operate, you could create another subsection like HTTP Timeouts explaining how to configure this.
Do you think that those environment variables should be added also to the helm chart?

@JorTurFer
Copy link
Member

We also need that you sign all the commits that you do. This link explains how to solve with already created commits

@wltbenade
Copy link
Contributor Author

Thanks, @JorTurFer! Appreciate the quick response :)

I'll resubmit the PR with signed commits, and submit a PR to keda-docs.

Signed-off-by: Louwrens Benade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants