-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a scaler based on a GCP Stackdriver metric #2758
Conversation
/run-e2e gcp-stackdriver.test.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @RamCohen! Keep it coming :)
@RamCohen one last nit, update Changelog please 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Only small nit inline (not blocker)
It seems that you have any commit that it's not singed. |
07df3da
to
40b28f4
Compare
Add a scaler based on a metric value obtained from GCP Stackdriver Fixes: 2661 Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
Signed-off-by: Ram Cohen <[email protected]>
d6232ca
to
5b96ba7
Compare
/run-e2e gcp-stackdriver.test.ts |
Thanks a lot @RamCohen! |
feat: Add a scaler based on a GCP Stackdriver metric
Add a scaler based on a metric value obtained from GCP Stackdriver
Fixes: #2661
Signed-off-by: Ram Cohen [email protected]