Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Makefile mockgen targets #2137

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Add Makefile mockgen targets #2137

merged 1 commit into from
Oct 4, 2021

Conversation

mihaitodor
Copy link
Contributor

@mihaitodor mihaitodor commented Oct 2, 2021 •
edited
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added - will be triggered each time make build is run
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified) - N/A
  • A PR is opened to update the documentation on (repo) (if applicable) - N/A
  • Changelog has been updated

Fixes #2090.

mihaitodor
mihaitodor commented Oct 2, 2021
View reviewed changes
Makefile Show resolved Hide resolved
@mihaitodor mihaitodor mentioned this pull request Oct 2, 2021
Closed
@mihaitodor mihaitodor force-pushed the add-mockgen-makefile branch from 59f03a5 to 996b0a1 Compare October 2, 2021 18:27
zroubalik
zroubalik approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

CHANGELOG.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@mihaitodor mihaitodor force-pushed the add-mockgen-makefile branch from 996b0a1 to 9e028b0 Compare October 4, 2021 08:49
@mihaitodor
Copy link
Contributor Author

@zroubalik Looks like I was a bit too eager to rebase on main. The last commit broke the build since func getFromAuthOrMeta was added to both pkg/scalers/mysql_scaler.go and pkg/scalers/mongo_scaler.go.

@zroubalik
Copy link
Member

@zroubalik Looks like I was a bit too eager to rebase on main. The last commit broke the build since func getFromAuthOrMeta was added to both pkg/scalers/mysql_scaler.go and pkg/scalers/mongo_scaler.go.

yeah, we are solving this in a separate issue. I'll ping you once it is done so you can do the final rebase, thanks!

@zroubalik
Copy link
Member

@mihaitodor rebase please

@mihaitodor
Add Makefile mockgen targets
0c37824 
Signed-off-by: Mihai Todor <[email protected]>
@mihaitodor mihaitodor force-pushed the add-mockgen-makefile branch from 9e028b0 to 0c37824 Compare October 4, 2021 15:37
@mihaitodor
Copy link
Contributor Author

@zroubalik Done, thanks!

@zroubalik zroubalik merged commit a1b7214 into kedacore:main Oct 4, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@mihaitodor @nilayasiktoprak
Add Makefile mockgen targets (kedacore#2137)
647c809 
Signed-off-by: Mihai Todor <[email protected]>
Signed-off-by: nilayasiktoprak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add automatic mockgen for pkg/mock
2 participants
@mihaitodor @zroubalik