Helm CRD deployment/deletion #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee0c
changed the title
ahmelsayed
reviewed
Apr 23, 2019
| apiVersion: apiextensions.k8s.io/v1beta1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| name: scaledobjects.kore.k8s.io | ||
| annotations: | ||
| "helm.sh/hook": crd-install | ||
| # This will delete the CRD before any attempt to install it | ||
| # However, it only works if you use the --wait option on `helm install` | ||
| "helm.sh/hook-delete-policy": "before-hook-creation" |
There was a problem hiding this comment.
I wasn't clear about this in the meeting today. Would this cause all ScaledObjects to get deleted on update?
There was a problem hiding this comment.
On update, no. They would only get wiped if you were doing a fresh helm install after deleting the deployment. If we don't want people to unintentionally wipe them, I can revert that and just leave in the var that lets you not create the CRD.
|
You'll need to rebase your pr. The file names changed so keep that in mind. |
|
Will rebase at some point this afternoon, I have been at an event and am catching up on all the changes. |
lee0c
force-pushed
the
helm-crd-fix
branch
2 times, most recently
from
8a22d25 to
68260af
Compare
|
@Aarthisk I'd love to see this merged or closed, just rebased again so it is up to date |
patnaikshekhar
pushed a commit
to patnaikshekhar/keda
that referenced
this pull request
Jul 17, 2019
Helm CRD deployment/deletion Former-commit-id: 13071d2
Aarthisk
pushed a commit
that referenced
this pull request
Aug 12, 2019
Helm CRD deployment/deletion Former-commit-id: 3405d42
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Tom Kerkhove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Added hook to delete CRD before reinstall - still not sure if this is the preferable pathKilled this. I think we should go with the route least likely to suddenly wipe someone's setupNot sure which of the paths mentioned in linked issue is preferred - delete CRD w/ deployment, or delete CRD before attempting to install?