Fix Pulsar to work correctly without auth (#5284)

Signed-off-by: Zbynek Roubalik <[email protected]>
kedacore · Dec 13, 2023 · 923583f · 923583f
1 parent 6355aa0
commit 923583f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -83,6 +83,7 @@ Here is an overview of all new **experimental** features:
 - **Azure Pipelines**: No more HTTP 400 errors produced by poolName with spaces ([#5107](https://github.com/kedacore/keda/issues/5107))
 - **GCP pubsub scaler**: Added `project_id` to filter for metrics queries ([#5256](https://github.com/kedacore/keda/issues/5256))
 - **GCP pubsub scaler**: Missing use of default value of `value` added ([#5093](https://github.com/kedacore/keda/issues/5093))
+- **Pulsar scaler**: Fix panic when auth is not used ([#5271](https://github.com/kedacore/keda/issues/5271))
 - **ScaledJobs**: Copy ScaledJob annotations to child Jobs ([#4594](https://github.com/kedacore/keda/issues/4594))
 
 ### Deprecations

diff --git a/pkg/scalers/pulsar_scaler.go b/pkg/scalers/pulsar_scaler.go
@@ -251,7 +251,7 @@ func (s *pulsarScaler) GetStats(ctx context.Context) (*pulsarStats, error) {
 	}
 
 	client := s.client
-	if s.metadata.pulsarAuth.EnableOAuth {
+	if s.metadata.pulsarAuth != nil && s.metadata.pulsarAuth.EnableOAuth {
 		config := clientcredentials.Config{
 			ClientID:       s.metadata.pulsarAuth.ClientID,
 			ClientSecret:   s.metadata.pulsarAuth.ClientSecret,