Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landing page look improvements and footer improvements #794

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

reveurguy
Copy link
Contributor

Signed-off-by: Priyanshu Singh [email protected]

landing page look improvements and footer improvements

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@netlify
Copy link

netlify bot commented Jun 25, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 9bb36de
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/62b6fe6926733500075fd04d
😎 Deploy Preview https://deploy-preview-794--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JorTurFer
Copy link
Member

I like the change but I'm not sure about the hover
image

is it a pre step to another thing?

@reveurguy
Copy link
Contributor Author

I like the change but I'm not sure about the hover image

is it a pre step to another thing?

Thanks. No it's not a pre-step, it's just something visually nice for all the headings.

@JorTurFer
Copy link
Member

Thanks. No it's not a pre-step, it's just something visually nice for all the headings.

An important disclaimer, my "design" capabilities are more or less the same that a dog or cat could have, so it's not a blocker from my side. It looks nice ❤️

@tomkerkhove
Copy link
Member

I like the extra touch - Let's keep it in and revert if it's too annoying for everyone

@tomkerkhove tomkerkhove merged commit 60ddb3d into kedacore:main Jun 27, 2022
@reveurguy
Copy link
Contributor Author

I like the extra touch - Let's keep it in and revert if it's too annoying for everyone

yeah sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants