Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain the differences between activation and scaling values #780

Merged
merged 13 commits into from
Jun 27, 2022

Conversation

JorTurFer
Copy link
Member

Signed-off-by: Jorge Turrado [email protected]

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related kedacore/keda#2800

@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 6fbe7ab
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/62b9508db5e4a00009522930
😎 Deploy Preview https://deploy-preview-780--keda.netlify.app/docs/2.8/concepts/scaling-deployments
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JorTurFer JorTurFer changed the title docs: Explain the differences between activation and scaling values docs: explain the differences between activation and scaling values Jun 13, 2022
JorTurFer and others added 8 commits June 16, 2022 20:48
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 16, 2022

PTAL @zroubalik @tomkerkhove ,
I have refactored it a bit since the last review to explain better what means activating and what means scaling

Signed-off-by: Jorge Turrado <[email protected]>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple of nits.

content/docs/2.8/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
content/docs/2.8/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
content/docs/2.8/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
content/docs/2.8/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
content/docs/2.8/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
content/docs/2.8/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
Signed-off-by: Jorge Turrado <[email protected]>
@tomkerkhove tomkerkhove merged commit a2e9daf into kedacore:main Jun 27, 2022
@JorTurFer JorTurFer deleted the doc-activation branch June 27, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants