Adding update for redis lists #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Travis Bickford <[email protected]>
tbickford
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
tomkerkhove
reviewed
Aug 3, 2020
Signed-off-by: Travis Bickford <[email protected]>
tomkerkhove
approved these changes
Aug 4, 2020
|
@tomkerkhove @tbickford what is the status of this? |
I thought this was good to go or did I miss something? |
|
I've added some suggestions above but they are nits, for the rest I'm fine. Up to you folks. |
Signed-off-by: Travis Bickford <[email protected]>
My bad - I had thought I addressed those items. I pushed an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pertains to the PR I have made for adding the optional authentication params for the Redis Scaler (kedacore/keda#962). Added some additional wording around the use of those attributes as env vars. I added this to the
2.0version and created a new version1.6as I would think it would go out with the next release? Is there another branch I should be using as the base besides the master branch for potential adds in the next release?