Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add docs for Google Cloud Tasks scaler #1202

Merged
merged 7 commits into from
Sep 11, 2023
Merged

feat: add docs for Google Cloud Tasks scaler #1202

merged 7 commits into from
Sep 11, 2023

Conversation

jmalvarezf-lmes
Copy link
Contributor

@jmalvarezf-lmes jmalvarezf-lmes commented Aug 3, 2023 •
edited by zroubalik
Loading

This is the docs part corresponding to the cloud tasks scaler PR

Relates: kedacore/keda#3613

feature: add docs for cloud tasks scaler
5369648 
Signed-off-by: Jose Maria Alvarez <[email protected]>
@jmalvarezf-lmes jmalvarezf-lmes requested a review from a team as a code owner August 3, 2023 12:52
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify
Copy link

netlify bot commented Aug 3, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 35861ef
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/64f74f381b369800084f42e0
😎 Deploy Preview https://deploy-preview-1202--keda.netlify.app/docs/2.12/scalers/gcp-pub-sub
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmalvarezf-lmes
Copy link
Contributor Author

I've seen that the page generates this:

<p>Warning</p></div><div class=message-body> You are currently viewing v"2.12" of the documentation and it is not the latest. For the most recent documentation, kindly <a href=/docs/2.11/scalers/gcp-cloud-tasks/> click here.</a>

It seems as if the latest release wasn't linked to 2.12, but to 2.11. Please let me know what to do.

@JorTurFer
Copy link
Member

That's because there are some links to latest, and latest is v2.11, which doesn't contain this code (and it's correct). Here is explained why: #721

to fix it, add the ignores to missing files as here: https://github.com/kedacore/keda-docs/pull/722/files

@jmalvarezf-lmes
Copy link
Contributor Author

Ok, done, thank you for the tip!

tomkerkhove
tomkerkhove approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor nits

.htmltest.yml Show resolved Hide resolved
content/docs/2.12/scalers/gcp-cloud-tasks.md Outdated Show resolved Hide resolved
content/docs/2.12/scalers/gcp-cloud-tasks.md Show resolved Hide resolved
content/docs/2.12/scalers/gcp-cloud-tasks.md Show resolved Hide resolved
jmalvarezf-lmes and others added 2 commits August 11, 2023 09:20
@jmalvarezf-lmes @tomkerkhove
Update content/docs/2.12/scalers/gcp-cloud-tasks.md
9882875 
Neat

Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jose Maria Alvarez Fernandez <[email protected]>
@jmalvarezf-lmes @tomkerkhove
Update content/docs/2.12/scalers/gcp-cloud-tasks.md
5795fc9 
Neating code

Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Jose Maria Alvarez Fernandez <[email protected]>
@jmalvarezf-lmes @JorTurFer
Update content/docs/2.12/scalers/gcp-cloud-tasks.md
0595b7c 
Document both value and activationValue

Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jose Maria Alvarez Fernandez <[email protected]>
@zroubalik zroubalik changed the title feature: add docs for cloud tasks scaler feat: add docs for Google Cloud Tasks scaler Aug 16, 2023
Jose Maria Alvarez added 2 commits September 5, 2023 17:53
fix: add all parameters in same list
87815a0 
Signed-off-by: Jose Maria Alvarez <[email protected]>
Merge branch 'feature/google_cloud_tasks_scaler' of github.com:jmalva…
35861ef 
…rezf-lmes/keda-docs into feature/google_cloud_tasks_scaler
zroubalik
zroubalik approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer JorTurFer merged commit f398b1a into kedacore:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmalvarezf-lmes @JorTurFer @zroubalik @tomkerkhove