doc(pubsub): supports PullAckRequestCount
#1071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Chung <[email protected]>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
5 tasks
tomkerkhove
reviewed
Feb 16, 2023
| The mode chooses whether to scale using number of messages `SubscriptionSize` or using oldest unacked message age `OldestUnackedMessageAge`. | ||
| The `value` determines the target average which the deployment will be scaled on. The default value is 5 for `SubscriptionSize` and 10 for `OldestUnackedMessageAge`. | ||
|
|
||
| The `mode` chooses whether to scale using |
There was a problem hiding this comment.
Suggested change
| The `mode` chooses whether to scale using | |
| `mode` defines what input scaling should be based on: |
Comment on lines
+40
to
+42
| - `SubscriptionSize`: number of messages | ||
| - `OldestUnackedMessageAge`: oldest unacked message age | ||
| - `PullAckRequestCount`: pull ack request count |
There was a problem hiding this comment.
Suggested change
| - `SubscriptionSize`: number of messages | |
| - `OldestUnackedMessageAge`: oldest unacked message age | |
| - `PullAckRequestCount`: pull ack request count | |
| - `SubscriptionSize`: The number of messages | |
| - `OldestUnackedMessageAge`: The age of the oldest unacknowledged message | |
| - `PullAckRequestCount`: The amount of pull ack request count |
Can you elaborate what "pull ack request count" means? This might be unclear for people that are new to this scaler
|
@tomkerkhove Thanks for your review! I decide to close this PR first and wait for the discussion on kedacore/keda#4243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Ref
kedacore/keda#4239