Skip to content

rename test case to better describe error #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

alightgoesout
Copy link
Contributor

After removing the requirements to have spaces before node children (#499), I feel like test cases brackets_in_bare_id_fail.kdl is poorly named.

foo123{bar}foo weeee

This test should still fail, but for different reasons. The name suggest foo123{bar}foo is not a valid identifier, but it should now be parsed as foo123 { bar }. It fails because there are no node separator between the first node and the second one (foo weeee).

I have looked and found no test that check a similar case, so I have renamed the test case to semicolon_after_children_fail.kdl, but feel free to suggest other names.

@tabatkins
Copy link
Contributor

This sounds completely reasonable, but I think the name still sounds misleading. ^_^ Perhaps semicolon_missing_after_children_fail?

@alightgoesout
Copy link
Contributor Author

Yes, you're right. I have renamed the file accordingly.

@tabatkins tabatkins merged commit a88c450 into kdl-org:main Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants