rename test case to better describe error #509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing the requirements to have spaces before node children (#499), I feel like test cases
brackets_in_bare_id_fail.kdl
is poorly named.This test should still fail, but for different reasons. The name suggest
foo123{bar}foo
is not a valid identifier, but it should now be parsed asfoo123 { bar }
. It fails because there are no node separator between the first node and the second one (foo weeee
).I have looked and found no test that check a similar case, so I have renamed the test case to
semicolon_after_children_fail.kdl
, but feel free to suggest other names.