Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ensure output of illegal bare ident is quoted #178

Merged
merged 1 commit into from
Sep 17, 2021
Merged

tests: ensure output of illegal bare ident is quoted #178

merged 1 commit into from
Sep 17, 2021

Conversation

benjreinhart
Copy link
Contributor

I noticed the readme still had a bare identifier with a forward slash in it. When I searched for that identifier, I found one more reference to it in the expected_kdl folder. Similar to #166, I believe that expected result needs to be updated since the identifier contains a forward slash (in this case, wrapping it with quotes like its input text).

@benjreinhart benjreinhart changed the title tests: ensure output of illegal ident is quoted tests: ensure output of illegal bare ident is quoted Sep 17, 2021
Copy link
Member

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Nice catch :)

@zkat zkat merged commit 8ca18fe into kdl-org:main Sep 17, 2021
@benjreinhart benjreinhart deleted the bare_id_updates branch September 17, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants