Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes shellcheck warnings #75

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Fixes shellcheck warnings #75

merged 6 commits into from
Aug 28, 2023

Conversation

Arkoprabho
Copy link
Contributor

Related to #74

  • Removed unused variables (SC2034)
  • Declare and assign variables separately (SC2155)
  • Double quotes for variables (SC2086) (SC2206)
  • Replace expr (SC2003)

@Arkoprabho
Copy link
Contributor Author

Thinking of breaking down the PRs. This will address the shellcheck warnings.
Will raise another to fix broken tests_all

cclauss
cclauss reviewed Aug 22, 2023
View reviewed changes
@cclauss
Copy link
Contributor

cclauss commented Aug 24, 2023

@kdabir Can you please approve this workflow run below so we can ensure this workflow will pass?

cclauss
cclauss approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdabir kdabir merged commit 61032d6 into kdabir:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arkoprabho @cclauss @kdabir