Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#223] Processing tables with incorrect quoting #299

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[#223] Processing tables with incorrect quoting #299

wants to merge 5 commits into from

Conversation

MSattrtand
Copy link
Collaborator

@MSattrtand MSattrtand commented Feb 6, 2025 •
edited
Loading

Resolves #223

@MSattrtand MSattrtand requested a review from blcham February 11, 2025 08:46
blcham
blcham approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although i have one suggestion for improvement.

Good job !! (if i assume it works ;)

s-pipes-modules/module-tabular/src/test/resources/examples/invalidQuoting/input.csv
@@ -0,0 +1,4 @@
A,B,C
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand values 1 2 3 4 5 6 7 ... that is pitty. How about adding something that at least indicated where the value belongs, e.g.:

A, B, C
1A, 1B, 1C
2A, 2B, 2C

i.e. first line would be:
1A,"1B " 1B",1C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabular module ignores ending quote
2 participants
@MSattrtand @blcham