Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for kbss-cvut/csat-maintenance-planner#93 - Fix missing task descriptions #143

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

kostobog
Copy link
Collaborator

@kostobog kostobog commented Dec 9, 2022

@LaChope @blcham
Partially fixes - kbss-cvut/csat-maintenance-planner#93

[FIX] IF task types referenced in work sessions does not have a label set it to the label of the definition task type

  • add code to set null titles of task types in RevisionHistory.loadAllClosedRevisionsWorkLog that normalizes task types referenced in work sessions
  • add method TaskTypeService.getTaskTypes to get all task types.

… set it to the label of the definition task type

- add code to set null titles of task types in RevisionHistory.loadAllClosedRevisionsWorkLog that normalizes task types referenced in work sessions
- add method TaskTypeService.getTaskTypes to get all task types.
@kostobog kostobog requested a review from LaChope December 9, 2022 11:11
@kostobog kostobog assigned kostobog and unassigned kostobog Dec 9, 2022
@blcham
Copy link
Contributor

blcham commented Dec 9, 2022

LGTM, leaving review to @LaChope

Copy link
Collaborator

@LaChope LaChope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, LGTM

@kostobog kostobog merged commit b0a4dc6 into main Dec 9, 2022
@blcham blcham deleted the issues/missing-task-description branch February 15, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants