Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect events for analytics #77

Merged
merged 3 commits into from
May 31, 2021
Merged

Collect events for analytics #77

merged 3 commits into from
May 31, 2021

Conversation

PrasadG193
Copy link
Member

  • Add new command kbrew analytics to check status and turn on/off the analytics collection
  • Collect following events: install-success, install-fail, install-timeout and k8s-events
  • Collect and report k8s-events in case of install-fail and install-timeout.
  • k8s-events are the Warning level events for involved Pods

@PrasadG193
Collect events for analytics
65cdc35 
Signed-off-by: Prasad Ghangal <[email protected]>
@PrasadG193 PrasadG193 requested review from sahil-lakhwani and vishal-biyani and removed request for sahil-lakhwani and vishal-biyani May 27, 2021 06:02
sahil-lakhwani
sahil-lakhwani reviewed May 28, 2021
View reviewed changes
Copy link
Contributor

@sahil-lakhwani sahil-lakhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are now many kube clients being created. We should follow up with a PR to have a global client if possible.

pkg/kube/kube.go Show resolved Hide resolved
pkg/events/events.go Show resolved Hide resolved
pkg/config/config.go Show resolved Hide resolved
PrasadG193 added 2 commits May 30, 2021 17:15
@PrasadG193
Fix golint issues
9b55c4d 
Signed-off-by: Prasad Ghangal <[email protected]>
@PrasadG193
Happy govet
b0186c8 
Signed-off-by: Prasad Ghangal <[email protected]>
@PrasadG193 PrasadG193 requested a review from sahil-lakhwani May 30, 2021 11:47
@PrasadG193 PrasadG193 merged commit 7edf4a8 into main May 31, 2021
@PrasadG193 PrasadG193 deleted the collect-events branch May 31, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil-lakhwani sahil-lakhwani sahil-lakhwani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrasadG193 @sahil-lakhwani