Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom wait-for-ready timeout #76

Merged
merged 1 commit into from
May 26, 2021
Merged

Support custom wait-for-ready timeout #76

merged 1 commit into from
May 26, 2021

Conversation

PrasadG193
Copy link
Member

  • Add new flag --timeout to override default timeout
  • Use consistent timeout for raw and helm apps

Example:

$ kbrew install mysql --timeout 10m

Fixes: #75

@PrasadG193 PrasadG193 requested a review from sahil-lakhwani May 25, 2021 15:57
@PrasadG193 PrasadG193 changed the title Support custom wait for ready timeout Support custom wait-for-ready timeout May 25, 2021
sahil-lakhwani
sahil-lakhwani approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@sahil-lakhwani sahil-lakhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PrasadG193 PrasadG193 merged commit 417649a into main May 26, 2021
@PrasadG193 PrasadG193 deleted the add-timeout branch May 26, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil-lakhwani sahil-lakhwani sahil-lakhwani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a flag to set custom wait for ready timeout
2 participants
@PrasadG193 @sahil-lakhwani