Skip to content

Commit

Permalink
rolling rollbacking should deregister the current taskdef after compl…
Browse files Browse the repository at this point in the history
…ated.
  • Loading branch information
fujiwara committed Mar 7, 2024
1 parent e30044e commit 29d7256
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 211 deletions.
2 changes: 1 addition & 1 deletion rollback.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ func (d *App) RollbackServiceTasks(ctx context.Context, sv *Service, opt Rollbac
); err != nil {
return "", err
}
return targetArn, nil
return currentArn, nil
}

func (d *App) RollbackByCodeDeploy(ctx context.Context, sv *Service, opt RollbackOption) (string, error) {
Expand Down
87 changes: 0 additions & 87 deletions tests/ci/ecs-service-def.json

This file was deleted.

123 changes: 0 additions & 123 deletions tests/ci/ecs-task-def.json

This file was deleted.

0 comments on commit 29d7256

Please sign in to comment.