feat: Now external file links like [[file:foo.org::* Heading]] work #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, only [[file:foo.org::#custom_id]] worked.
|
This change breaks the links to other subtree posts in the same file.. Will need to dig deeper.. |
Also fix a test post subtree at wrong indentation level
- An EXPORT_FILE_NAME subtree was nested inside another
EXPORT_FILE_NAME subtree. Post subtrees are not supposed to be
organized like that.
This applies only to the case where the search string is a target name and the search is attempted in a different file.
Thanks to the magical Org Element API function `org-element-target-parser` :)
Also fix a duplicate ID
kaushalmodi
force-pushed
the
fix-links-to-headings-in-other-files
branch
from
2ea9167 to
0451eb9
Compare
[skip ci]
kaushalmodi
force-pushed
the
fix-links-to-headings-in-other-files
branch
from
467c861 to
27c3cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, only [[file:foo.org::#custom_id]] worked.