Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape any double quote already in value when wrapping it in quotes #47

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

punchagan
Copy link
Contributor

Toml front matter is unparseable when a post title has a " in it. This PR fixes that.

@punchagan punchagan force-pushed the fix-double-quote-in-value branch from 769866f to c7bcd23 Compare July 24, 2017 15:17
@kaushalmodi
Copy link
Owner

Thanks for the PR (and in the process trying out ox-hugo)!

I see your commit on emacs master here, but it does not have the TINY CHANGE qualifier. So am I right in assuming that you have the FSF copyright assignment in place? :)

I'll review and merge it today. This PR made me think that the description meta-data could also have double quotes.. but from a quick glance, this PR probably deals with that too.

@punchagan
Copy link
Contributor Author

Thank you for your work on ox-hugo! And yes, I do have copyright assignment in place.

I've been meaning to try hugo for a while now, and I'm amazed at how fast it is. I've tried goorgeous, but I see how difficult it can be to port all the crazy number of org features to another implementation! I'm hopeful, though, that ox-hugo will give a workflow that feels almost as smooth and "stays-out-of-my-way" as something one would get with using hugo+markdown directly.

@kaushalmodi
Copy link
Owner

I've tried goorgeous, but I see how difficult it can be to port all the crazy number of org features to another implementation!

Exactly! :)

I'm hopeful, though, that ox-hugo will give a workflow that feels almost as smooth and "stays-out-of-my-way" as something one would get with using hugo+markdown directly.

That's the idea.. One of my mottos for ox-hugo is to do as much implicit front matter derivation from Org meta-data as possible... the "stays-out-of-my-way" part. I shouldn't have to worry about manually updating tags of related posts.. just dump them in a subtree with a tag I want. That's one example.

@kaushalmodi kaushalmodi merged commit ecb7119 into kaushalmodi:master Jul 24, 2017
@kaushalmodi
Copy link
Owner

Thanks! It's merged.

In the process of testing quotes in description, I realized that description parsing was broken (now fixed: 8db5048 ).

Also, commit the exported .md files for all tests, so that we know what the expected output should be. I did that for the test you added (thanks!) in the above commit as well.

@punchagan punchagan deleted the fix-double-quote-in-value branch July 24, 2017 16:46
@punchagan
Copy link
Contributor Author

That's the idea.. One of my mottos for ox-hugo is to do as much implicit front matter derivation from Org meta-data as possible... the "stays-out-of-my-way" part. I shouldn't have to worry about manually updating tags of related posts.. just dump them in a subtree with a tag I want. That's one example.

Yes, it does become apparent looking at the README and some of the features that you are trying to make the whole workflow as hassle free as possible. That's what made me try it out! 👍

Also, commit the exported .md files for all tests, so that we know what the expected output should be. I did that for the test you added (thanks!) in the above commit as well.

I'll keep that in mind, next time. Thanks for taking care of it this time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants