Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and remove the "_" to "%5f" hack added for Blackfriday.. may be that's not needed with Goldmark #308

Closed
kaushalmodi opened this issue Nov 30, 2019 · 1 comment · Fixed by #494
Closed

Investigate and remove the "_" to "%5f" hack added for Blackfriday.. may be that's not needed with Goldmark #308

kaushalmodi opened this issue Nov 30, 2019 · 1 comment · Fixed by #494
Labels
goldmark requirement/spec

Comments

@kaushalmodi
Copy link
Owner

No description provided.

@kaushalmodi kaushalmodi mentioned this issue Mar 16, 2020
Closed
@luketurner
Copy link

luketurner commented Apr 3, 2021 •
edited
Loading

I encountered issues with the %5F a while back -- It was breaking links, specifically, Github links, like in the linked issue. Maybe whether it breaks or not is dependent on how the server is parsing their path segments?

e.g.:

At least on my computer (Windows+Firefox) the first link works, the second returns a Page not found. (Edit: Actually, both links work for me in Chrome.)

Anyway, I guessed it was due to Hugo's switch to Goldmark (I'm currently using Hugo v0.81.0) and have been running without the org-blackfriday--url-sanitize call for a while.

By the way -- thank you for the awesome package! Ox-hugo is great!

(Edit: Looking around the repo more, I see a fair bit of discussion around this already in other issues -- sorry if this was unnecessary information!)

kaushalmodi added a commit that referenced this issue Jan 4, 2022
@kaushalmodi
Don't replace _ in links with %5f if using Goldmark
2d91428 
Users running Hugo 0.60 or newer versions are using Goldmark by
default. But, in any case, if you are reading this commit because you
are still using Blackfriday and also happen to have italicized links
with underscores in them, set `org-hugo-goldmark` to nil.

See #485 for more
info.

Fixes #308.

This commit supersedes this PR: #403
@kaushalmodi kaushalmodi mentioned this issue Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
goldmark requirement/spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't replace _ in links with %5f if using Goldmark kaushalmodi/ox-hugo
2 participants
@luketurner @kaushalmodi