This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
golangci-ling: disable unconverted until it can support -- all flag #4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
egernst
force-pushed
the
topic/unconvert
branch
from
effa73d to
1cf8eae
Compare
|
/test |
egernst
added a commit
to egernst/kata-containers
that referenced
this pull request
Feb 25, 2022
Their types may differ on various host OSes, but unix.Major|Minor always takes a uint64 Depends-on: github.com/kata-containers/tests#4516 Signed-off-by: Eric Ernst <[email protected]>
|
/test |
We've seen instances of casting's being flagged on linux, when they are necessary running on other OSs (Darwin). While unconvert does have an "all" option where it'll check OS/Arch combinations, this isn't exposed in golangci-lint. Let's disable for now. Fixes: kata-containers#4517 Signed-off-by: Eric Ernst <[email protected]>
egernst
changed the title
|
/test |
egernst
force-pushed
the
topic/unconvert
branch
from
1cf8eae to
1f3b2c6
Compare
|
/test |
sameo
approved these changes
Feb 27, 2022
sameo
pushed a commit
to egernst/kata-containers
that referenced
this pull request
Feb 27, 2022
Their types may differ on various host OSes, but unix.Major|Minor always takes a uint64 Depends-on: github.com/kata-containers/tests#4516 Signed-off-by: Eric Ernst <[email protected]>
Jakob-Naucke
approved these changes
Feb 28, 2022
egernst
added a commit
to egernst/kata-containers
that referenced
this pull request
Feb 28, 2022
Their types may differ on various host OSes, but unix.Major|Minor always takes a uint64 Depends-on: github.com/kata-containers/tests#4516 Signed-off-by: Eric Ernst <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently unconvert static check will fail for some host operating systems, but pass on others. Example, see kata-containers/kata-containers#3774 (comment)
It looks like this isn't supported in golangci-lint at this point: golangci/golangci-lint#1809
Let's drop until golangci-lint supports this.