Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

kernel: build: Use local kernel version. #300

Merged
merged 4 commits into from
Jan 9, 2019

Conversation

jcvenegas
Copy link
Member

If the runtime repository is already cloned get version from it,
else keep getting from github.

Fixes: #299

Signed-off-by: Jose Carlos Venegas Munoz [email protected]

If the runtime repository is already cloned get version from it,
else keep getting from github.

Fixes: kata-containers#299

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@jcvenegas
Copy link
Member Author

Lets wait to merge, kata-containers/tests#1032 first.

@jcvenegas
Copy link
Member Author

/test

Copy link
Contributor

@chavafg chavafg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Kernele changes are not being detected, fix it.

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@jcvenegas
Copy link
Member Author

/test

Kernel dir changed.

Depends-on:github.com/kata-containers/tests#1033

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@jcvenegas jcvenegas force-pushed the use-local-kernel-version branch from 1f8d442 to 789970b Compare January 8, 2019 23:29
@jcvenegas
Copy link
Member Author

/test

@jcvenegas
Copy link
Member Author

Finally testing again the kernel PRs,

Check Changes in kernel ...

@jodh-intel
Copy link
Contributor

CI failing:

Setup a default again wont download again the kernel
/tmp/jenkins/workspace/kata-containers-packaging-ubuntu-16-04-PR/go/src/github.com/kata-containers/packaging/.ci/../Makefile:36: recipe for target 'test-build-kernel' failed
make[1]: *** [test-build-kernel] Error 1

print output from  last command that failed.

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@jcvenegas
Copy link
Member Author

/test

@devimc
Copy link

devimc commented Jan 9, 2019

Thanks @jcvenegas
lgtm

Approved with PullApprove

@egernst egernst merged commit a60cd13 into kata-containers:master Jan 9, 2019
@jcvenegas jcvenegas deleted the use-local-kernel-version branch February 5, 2019 20:42
jcvenegas pushed a commit that referenced this pull request Jul 2, 2019
We should start this unit so that systemd can mount /tmp as
tmpfs.

Fixes #300

Signed-off-by: Archana Shinde <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants