Improve formatting in cri containerd howto #127

jodh-intel · 2018-05-25T10:43:29Z

Update how-to/how-to-use-k8s-with-cri-containerd-and-kata.md to improve the formatting.

The text was updated successfully, but these errors were encountered:

docs: Grammar and format updates Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as adddirect links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]>

Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as adddirect links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]> howto: k8s grammar and format changes Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as adddirect links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]>

Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as adddirect links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]> howto: k8s grammar and format changes Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as adddirect links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]> howto: k8s grammar and format changes Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as adddirect links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]>

Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as adddirect links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]> howto: k8s grammar and format changes Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as adddirect links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]>

Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as add direct links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]> howto: k8s grammar and format changes Went through and made a few grammar and format updates to make how-to guide easier to follow, as well as add direct links to project Github pages where applicable. Fixes: kata-containers#127 Signed-off-by: trilliams <[email protected]>

This PR is based on kata-containers#124 but has been reworked and updated to take into account review feedback and extra cleanups to bring this howto in line with the latest documentation requirements. Fixes kata-containers#127. Contributions-from: T. Nichole Williams <[email protected]> Signed-off-by: James O. D. Hunt <[email protected]>

This PR is based on kata-containers#124 but has been reworked and updated to take into account review feedback and extra cleanups to bring this howto in line with the latest documentation requirements. Fixes kata-containers#127. Signed-off-by: T. Nichole Williams <[email protected]> Signed-off-by: James O. D. Hunt <[email protected]>

The image_builder.sh script must be run as root. The following check is performed before the script checks for root: [ "${AGENT_INIT}" == "yes" ] || [ -x "${ROOTFS}/usr/bin/${AGENT_BIN}" ] || \ die "/usr/bin/${AGENT_BIN} is not installed in ${ROOTFS} use AGENT_BIN env variable to change the expected agent binary name" The -x test is "True if the file is executable by you". It may evaluate to true as root and false as non-root, depending on the file permissions. The permissions for kata-agent given in the Developer Guide are 0550 (https://github.com/kata-containers/documentation/blob/master/Developer-Guide.md#add-a-custom-agent-to-the-image---optional). Therefore image_builder.sh fails with "/usr/bin/${AGENT_BIN} is not installed" when run as non-root. This is confusing since the agent binary is really installed! Move the root check to the beginning of the script. This solves the confusing error and prevents similar problems where the script doesn't take into account that the user may be non-root. Fixes: kata-containers#127 Signed-off-by: Stefan Hajnoczi <[email protected]>

jodh-intel mentioned this issue May 25, 2018

Format update #124

Closed

jodh-intel self-assigned this Sep 24, 2018

jodh-intel mentioned this issue Sep 24, 2018

docs: Clean up k8s with cri-containerd howto #251

Merged

grahamwhaley closed this as completed in #251 Oct 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve formatting in cri containerd howto #127

Improve formatting in cri containerd howto #127

jodh-intel commented May 25, 2018

Improve formatting in cri containerd howto #127

Improve formatting in cri containerd howto #127

Comments

jodh-intel commented May 25, 2018