gptel-transient: tool selection using completing-read-multiple #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds infixes that use completing-read-multiple to add/remove tools to use in place of the sub menu suffix
`completing-read-multiple' for the tools option now only shows the relevant items with the category. Also correctly handle duplicate values.
|
Added the annotations: |
ahmed-shariff
force-pushed
the
transient-tool-crm
branch
from
8d4b7c5 to
b443bc9
Compare
|
Reviewing the video, seems pretty good. As our tool numbers grow, narrowing and completion seem like the right way. I can easily see the average gptel user having 50 tools by the end of the year. Did you incidentally create a programming interface so I can set tools by category from an Elisp program? |
|
Thanks for taking a look at this. I had not implemented programming interfaces for that. Though, it should be pretty straightforward to do? (setq gptel-tools (alist-get "emacs" gptel--known-tools nil nil #'string-equal))I remember seeing a discussion about having a programmatic interface tool use, but couldn't find it in a rush 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off this comment: #514 (comment)
This is a proposal for replacing the tool selection sub menu in gptel-menu with completing-read-multiple.
This replaces the gptel-tools prefix with infexes to (a) add, (b) remove and (c) remove-all tools. (a) and (b) use
completing-read-multiple. The candidate list in both would have the individual tools as well as the categories. When adding, if a category is selected, all tools related to that are added. The same would happen when removing.A quick demo of what it looks like for now:
Recording.2025-02-17.230051.mp4
What do you think about this?
TODO: