chore: Test restructure #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
byteZorvin
commented
Aug 1, 2024
byteZorvin
commented
- This adds file restructuring to testcases
Co-authored-by: Apoorv Sadana <[email protected]>
apoorvsadana
reviewed
Aug 1, 2024
There was a problem hiding this comment.
so we won't keep unit tests in the same file?
There was a problem hiding this comment.
Felt more sense to keep all the tests together, just a preference. Whats your take?
There was a problem hiding this comment.
i think the convention is to keep unit tests in same file in general (at least in rust so that you don't need to make functions public to test them)
There was a problem hiding this comment.
Have changed to keep the unit testcases with the contract, please do check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.