-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add user guide and tutorial doc of mcs #548
Conversation
1b7af22
to
aaaedec
Compare
053da37
to
7636967
Compare
/assign |
docs/userguide/service/multi-cluster-service-with-native-svc-access.mdx
Outdated
Show resolved
Hide resolved
4021cb0
to
f4cf6e5
Compare
/cc @XiShanYongYe-Chang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just some typos found.
...ugin-content-docs/current/userguide/service/multi-cluster-service-with-native-svc-access.mdx
Outdated
Show resolved
Hide resolved
...ugin-content-docs/current/userguide/service/multi-cluster-service-with-native-svc-access.mdx
Outdated
Show resolved
Hide resolved
i18n/zh/docusaurus-plugin-content-docs/current/tutorials/access-service-across-clusters.md
Outdated
Show resolved
Hide resolved
docs/resources/userguide/service/multiclusterservice/mcs-overview.png
Outdated
Show resolved
Hide resolved
Signed-off-by: jwcesign <[email protected]>
|
||
### Karmada has been installed | ||
|
||
We can install Karmada by referring to [Quick Start](https://github.com/karmada-io/karmada#quick-start), or directly run `hack/local-up-karmada.sh` script which is also used to run our E2E cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to inform users about hack/local-up-karmada.sh is used for e2e cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied from https://karmada.io/docs/next/userguide/scheduling/scheduler-estimator/#karmada-has-been-installed , I think it's ok
@@ -0,0 +1,108 @@ | |||
<mxfile host="Electron" modified="2024-01-09T11:15:29.317Z" agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) draw.io/21.6.8 Chrome/114.0.5735.289 Electron/25.5.0 Safari/537.36" etag="ZryrKlNv4eWpEWFRcYkw" version="21.6.8" type="device"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these codes the source code of your images? looks good~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's the source file of draw.io
/cc @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
doc: add user guide and tutorial doc of mcs
Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
none