Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #6066: Bump Go version to 1.22.11 #6070

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Automated cherry pick of #6066: Bump Go version to 1.22.11 #6070

merged 2 commits into from
Jan 21, 2025

Conversation

y1hao
Copy link
Contributor

@y1hao y1hao commented Jan 20, 2025 •
edited by RainbowMango
Loading

Cherry pick of #6066 on release-1.11.
#6066: Bump Go version to 1.22.11
For details on the cherry pick process, see the cherry pick requests page.

Karmada(release-1.11) now built with Golang v1.22.11.

y1hao added 2 commits January 21, 2025 10:40
@y1hao
Bump Go version to 1.22.11
3688925 
Signed-off-by: Yihao Wang <[email protected]>
@y1hao
Update test cert
30efde7 
Signed-off-by: Yihao Wang <[email protected]>
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2025
y1hao
y1hao commented Jan 20, 2025
View reviewed changes
go.mod
@@ -1,6 +1,6 @@
module github.com/karmada-io/karmada

go 1.22.7 // keep in sync with .go-version, Readme.md#Prerequisites, hack/util.sh
go 1.22.11 // keep in sync with .go-version and hack/util.sh
Copy link
Contributor Author

@y1hao y1hao Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is simply cherry-picked. But looks like release-1.11 has more things to keep in sync. Do I need to update Readme.mc#Reprequisites and also keep this note in this comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your carefulness presses me!
Thanks, but it seems the Readme.mc#Reprequisites was already updated on release-1.11, but the comment was left unaltered. So, this change is perfect!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.51%. Comparing base (27ae068) to head (30efde7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.11    #6070   +/-   ##
=============================================
  Coverage         31.51%   31.51%           
=============================================
  Files               645      645           
  Lines             54334    54334           
=============================================
  Hits              17122    17122           
+ Misses            36141    36140    -1     
- Partials           1071     1072    +1
Flag Coverage Δ
unittests 31.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango mentioned this pull request Jan 21, 2025
Closed
3 tasks
RainbowMango
RainbowMango approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I added a release notes to the PR description, by the way. Thanks!

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@karmada-bot karmada-bot merged commit 7d765e9 into karmada-io:release-1.11 Jan 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@chaosi-zju chaosi-zju Awaiting requested review from chaosi-zju

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@whitewindmills whitewindmills Awaiting requested review from whitewindmills

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@y1hao @codecov-commenter @karmada-bot @RainbowMango