Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for search multiClusterCache ReadinessCheck success #5846

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Nov 20, 2024

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

To adapt to new features of the Kubernetes community: Resilient Watchcache Initialization, we also need to modify the Karmada-search component because we also use the same cache.

After the Karmada-search component is started, PostStartHook is added to wait for the cache to be ready. In addition, related ut is modified.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-search: Implement search proxy cache initialization post-start-hook

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 20, 2024
@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the adjust-with-readinessCheck branch from 02f9e98 to e001898 Compare November 20, 2024 08:58
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango @ikaven1024

@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Wait for search multiClusterCache ReadinessCheck to be ok Wait for search multiClusterCache ReadinessCheck success Nov 20, 2024
@RainbowMango RainbowMango added this to the v1.12 milestone Nov 20, 2024
pkg/search/proxy/store/store.go Outdated Show resolved Hide resolved
pkg/search/proxy/store/multi_cluster_cache.go Show resolved Hide resolved
pkg/search/proxy/store/cluster_cache.go Outdated Show resolved Hide resolved
pkg/search/proxy/store/cluster_cache.go Show resolved Hide resolved
pkg/search/proxy/store/multi_cluster_cache.go Show resolved Hide resolved
pkg/search/proxy/store/multi_cluster_cache.go Outdated Show resolved Hide resolved
pkg/search/proxy/controller.go Show resolved Hide resolved
pkg/search/proxy/controller.go Show resolved Hide resolved
pkg/search/proxy/controller.go Show resolved Hide resolved
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the adjust-with-readinessCheck branch from e001898 to d841142 Compare November 21, 2024 13:20
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the adjust-with-readinessCheck branch from d841142 to 9367ca9 Compare November 21, 2024 13:29
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 48.71795% with 40 lines in your changes missing coverage. Please review.

Project coverage is 46.31%. Comparing base (c950edd) to head (9367ca9).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
pkg/search/proxy/controller.go 34.78% 15 Missing ⚠️
cmd/karmada-search/app/options/options.go 0.00% 13 Missing ⚠️
cmd/karmada-search/app/karmada-search.go 0.00% 9 Missing ⚠️
pkg/search/proxy/testing/mock_store.go 0.00% 2 Missing ⚠️
cmd/karmada-search/app/options/validation.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5846      +/-   ##
==========================================
+ Coverage   46.03%   46.31%   +0.28%     
==========================================
  Files         660      661       +1     
  Lines       53987    54364     +377     
==========================================
+ Hits        24851    25177     +326     
- Misses      27519    27562      +43     
- Partials     1617     1625       +8     
Flag Coverage Δ
unittests 46.31% <48.71%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@karmada-bot karmada-bot merged commit 079d0ab into karmada-io:master Nov 22, 2024
18 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the adjust-with-readinessCheck branch November 28, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants