Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5685: add ResourceSummary deep copy in general-estimator #5724

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Oct 23, 2024

Cherry pick of #5685 on release-1.11.
#5685: add ResourceSummary deep copy in general-estimator
For details on the cherry pick process, see the cherry pick requests page.

`karmada-scheduler`: Fixed unexpected modification of original `ResourceSummary` due to lack of deep copy.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2024
@RainbowMango RainbowMango mentioned this pull request Oct 23, 2024
3 tasks
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.92%. Comparing base (64ea647) to head (d346d43).

Files with missing lines Patch % Lines
pkg/estimator/client/general.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11    #5724      +/-   ##
================================================
- Coverage         31.48%   30.92%   -0.57%     
================================================
  Files               643      643              
  Lines             44467    54217    +9750     
================================================
+ Hits              14002    16768    +2766     
- Misses            29439    36423    +6984     
  Partials           1026     1026              
Flag Coverage Δ
unittests 30.92% <0.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 23, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit e8d81b6 into karmada-io:release-1.11 Oct 23, 2024
12 checks passed
@RainbowMango RainbowMango deleted the automated-cherry-pick-of-#5685-upstream-release-1.11 branch December 26, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants