Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update image tags for Karmada components to v1.11.1 #5707

Merged
merged 1 commit into from
Oct 19, 2024
Merged

chore: update image tags for Karmada components to v1.11.1 #5707

merged 1 commit into from
Oct 19, 2024

Conversation

MAVRICK-1
Copy link
Contributor

@MAVRICK-1 MAVRICK-1 commented Oct 18, 2024 •
edited by RainbowMango
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This PR updates the image tags for Karmada components, etcd, and kube-apiserver in the sample file from v1.8.0 to v1.11.1. Manual updates are necessary to reflect the latest version until dynamic configuration is implemented.

Which issue(s) this PR fixes:
Part of #5484 update sample file of karmada operator

Special notes for your reviewer:
This is a temporary manual update, as future plans involve implementing dynamic configuration.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 18, 2024
@karmada-bot
Copy link
Collaborator

Welcome @MAVRICK-1! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2024
@MAVRICK-1 MAVRICK-1 force-pushed the update-karmada-components-v1.11.0 branch from 0f3b10c to 44ba153 Compare October 18, 2024 06:41
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.74%. Comparing base (76e01b1) to head (29980be).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5707      +/-   ##
==========================================
+ Coverage   39.73%   39.74%   +0.01%     
==========================================
  Files         650      650              
  Lines       55125    55125              
==========================================
+ Hits        21904    21912       +8     
+ Misses      31811    31805       -6     
+ Partials     1410     1408       -2
Flag Coverage Δ
unittests 39.74% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

/retest
The failing tests seem unrelated.

• [FAILED] [100.431 seconds]
deployment replicas syncer testing when policy is Divided schedule type, propagate 1 replica but hpa minReplicas is 2 [It] propagate 1 replica but hpa minReplicas is 2
/home/runner/work/karmada/karmada/test/e2e/deploymentreplicassyncer_test.go:216

https://github.com/karmada-io/karmada/actions/runs/11398802772/job/31716645272?pr=5707

@zhzhuang-zju zhzhuang-zju mentioned this pull request Oct 18, 2024
Closed
5 tasks
RainbowMango
RainbowMango reviewed Oct 18, 2024
View reviewed changes
operator/config/samples/karmada.yaml Outdated
@@ -31,35 +31,35 @@ spec:
serviceSubnet: 10.96.0.0/12
karmadaAggregatedAPIServer:
imageRepository: docker.io/karmada/karmada-aggregated-apiserver
imageTag: v1.8.0
imageTag: v1.11.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.11.0 or v1.11.1? @zhzhuang-zju
I remember there was a bug in v1.11.0, #5550.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.11.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MAVRICK-1 Could you please update it to v1.11.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RainbowMango All image tags for Karmada components, etcd, and kube-apiserver to v1.11.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just karmada components, which imagetag is v1.8.0 before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RainbowMango thanks for pointing this out, and I also update the issue description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@RainbowMango
Copy link
Member

Fixes #5484 update sample file of karmada operator

@MAVRICK-1 The Fixes would close the original issue. You can change it to something like Part of #5484.

@MAVRICK-1
Copy link
Contributor Author

@RainbowMango done 👍

@MAVRICK-1 MAVRICK-1 changed the title chore: update image tags for Karmada components to v1.11.0 chore: update image tags for Karmada components to v1.11.1 Oct 19, 2024
@RainbowMango
Copy link
Member

I think after squashing the commits, everything is set.

@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Oct 19, 2024
@MAVRICK-1 MAVRICK-1 force-pushed the update-karmada-components-v1.11.0 branch from 4a477f9 to a3692e7 Compare October 19, 2024 04:45
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2024
@MAVRICK-1 MAVRICK-1 closed this Oct 19, 2024
@MAVRICK-1 MAVRICK-1 force-pushed the update-karmada-components-v1.11.0 branch from a3692e7 to ffbbe06 Compare October 19, 2024 04:53
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 19, 2024
@MAVRICK-1 MAVRICK-1 reopened this Oct 19, 2024
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2024
@MAVRICK-1
Copy link
Contributor Author

@RainbowMango done

RainbowMango
RainbowMango approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2024
@karmada-bot karmada-bot merged commit 645fbe9 into karmada-io:master Oct 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@calvin0327 calvin0327 Awaiting requested review from calvin0327

@chaosi-zju chaosi-zju Awaiting requested review from chaosi-zju

@zhzhuang-zju zhzhuang-zju Awaiting requested review from zhzhuang-zju

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MAVRICK-1 @karmada-bot @codecov-commenter @RainbowMango @zhzhuang-zju