Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5568: Avoid treating PVC managed by VolumeClaimTemplate as dependencies #5687

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented Oct 13, 2024

Cherry pick of #5568 on release-1.10.
#5568: fix sts pvc logic
Part of #5656
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Ignored StatefulSet Dependencies with PVCs created via the VolumeClaimTemplates.

Co-authored-by: yelshall <[email protected]>
Signed-off-by: Julian Lawrence <[email protected]>
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2024
@seanlaii seanlaii changed the title Automated cherry pick of #5568: fix sts pvc logic Automated cherry pick of #5568: Avoid treating PVC managed by VolumeClaimTemplate as dependencies Oct 13, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.37%. Comparing base (bc48a4f) to head (1b7a152).

Files with missing lines Patch % Lines
...resourceinterpreter/default/native/dependencies.go 82.35% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #5687      +/-   ##
================================================
+ Coverage         53.34%   53.37%   +0.03%     
================================================
  Files               253      253              
  Lines             20597    20613      +16     
================================================
+ Hits              10987    11002      +15     
- Misses             8878     8879       +1     
  Partials            732      732              
Flag Coverage Δ
unittests 53.37% <82.35%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@karmada-bot karmada-bot merged commit 18ce735 into karmada-io:release-1.10 Oct 14, 2024
12 checks passed
@seanlaii seanlaii deleted the automated-cherry-pick-of-#5568-upstream-release-1.10 branch October 14, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants