-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate fieldOverrider operation #5671
feat: validate fieldOverrider operation #5671
Conversation
Signed-off-by: chaunceyjiang <[email protected]>
71a7569
to
f45aedb
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5671 +/- ##
==========================================
- Coverage 36.56% 36.54% -0.03%
==========================================
Files 648 648
Lines 45079 45091 +12
==========================================
- Hits 16485 16480 -5
- Misses 27351 27367 +16
- Partials 1243 1244 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
/cc @RainbowMango @sophiefeifeifeiya PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: validate fieldOverrider operation
Which issue(s) this PR fixes:
Part of #5608
Special notes for your reviewer:
Does this PR introduce a user-facing change?: