-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposing structured field overrider API #5581
Proposing structured field overrider API #5581
Conversation
The API looks good. btw,
|
Thanks. Updated. |
06b2db5
to
0f2fc51
Compare
Signed-off-by: RainbowMango <[email protected]>
0f2fc51
to
8ad4b5a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5581 +/- ##
==========================================
- Coverage 34.87% 34.86% -0.01%
==========================================
Files 645 645
Lines 44833 44833
==========================================
- Hits 15637 15633 -4
- Misses 27991 27994 +3
- Partials 1205 1206 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Given our decision on #5449, we can now move this forward. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This PR proposes the API change to address the requirement of #5449.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
For example, if you want to modify the database's host and port in the following ConfigMap:
You can do that by leveraging the proposing API:
The OverridePolicy declares the replace the /database/host with
remote-db.example.com
and port with3307
.The expected result should be:
Does this PR introduce a user-facing change?: