-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmada-operator
: Grand proxy permission to system:admin
#5572
Conversation
system:admin
to proxy member clusters during installation to fix karmadactl command failure
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5572 +/- ##
==========================================
+ Coverage 33.93% 34.85% +0.92%
==========================================
Files 645 645
Lines 44857 44861 +4
==========================================
+ Hits 15220 15636 +416
+ Misses 28479 28019 -460
- Partials 1158 1206 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
364800b
to
a7db045
Compare
/cc @XiShanYongYe-Chang @zhzhuang-zju can you help doing a review |
@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: doing, a, review, can, you. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we need it.
LGTM
thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
/retitle |
system:admin
to proxy member clusters during installation to fix karmadactl command failurekarmada-operator
: Grand proxy permission to system:admin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, just some nits from me.
Signed-off-by: chaosi-zju <[email protected]>
a7db045
to
25357ee
Compare
/cc @RainbowMango ci is ready |
@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: ci, is, ready. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
auto authorize system:admin to proxy member clusters in operation install method
Which issue(s) this PR fixes:
Fixes #5571
Special notes for your reviewer:
test report:
Does this PR introduce a user-facing change?: