-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated --bind-address
and --bind-address
from karmada-scheduler-estimator
#5555
Remove deprecated --bind-address
and --bind-address
from karmada-scheduler-estimator
#5555
Conversation
Signed-off-by: wei-chenglai <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5555 +/- ##
==========================================
+ Coverage 34.14% 34.15% +0.01%
==========================================
Files 643 643
Lines 44524 44512 -12
==========================================
+ Hits 15203 15205 +2
+ Misses 28165 28152 -13
+ Partials 1156 1155 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retitle Remove deprecated |
--bind-address
and --bind-address
from karmada-scheduler-estimator
cc @whitewindmills would you like to take a look? |
thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #5547
Special notes for your reviewer:
Based on this comment, I assign different default values to
--metrics-bind-address
and--health-probe-bind-address
. I've chosen to align with other components by using8080
as the default for--metrics-bind-address
.Does this PR introduce a user-facing change?: