Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5487: fix: command create cannot specify the namespace #5513

Conversation

zhzhuang-zju
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju commented Sep 10, 2024

Cherry pick of #5487 on release-1.11.
#5487: fix: command create cannot specify the namespace
For details on the cherry pick process, see the cherry pick requests page.

`karmadactl`:Fixed the issue where commands `create`, `annotate`, `delete`, `edit`, `label`, and `patch` cannot specify the namespace flag.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@zhzhuang-zju zhzhuang-zju force-pushed the automated-cherry-pick-of-#5487-upstream-release-1.11 branch from 7ee0df2 to 7245378 Compare September 10, 2024 06:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 31.46%. Comparing base (2d11238) to head (7245378).
Report is 37 commits behind head on release-1.11.

Files with missing lines Patch % Lines
pkg/karmadactl/create/create.go 0.00% 5 Missing ⚠️
pkg/karmadactl/delete/delete.go 0.00% 5 Missing ⚠️
pkg/karmadactl/promote/promote.go 0.00% 4 Missing ⚠️
pkg/karmadactl/annotate/annotate.go 0.00% 2 Missing ⚠️
pkg/karmadactl/edit/edit.go 0.00% 2 Missing ⚠️
pkg/karmadactl/explain/explain.go 0.00% 2 Missing ⚠️
pkg/karmadactl/label/label.go 0.00% 2 Missing ⚠️
pkg/karmadactl/options/global.go 0.00% 2 Missing ⚠️
pkg/karmadactl/patch/patch.go 0.00% 2 Missing ⚠️
pkg/karmadactl/apiresources/apiresources.go 0.00% 1 Missing ⚠️
... and 9 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.11    #5513      +/-   ##
================================================
- Coverage         31.47%   31.46%   -0.02%     
================================================
  Files               643      643              
  Lines             44432    44449      +17     
================================================
- Hits              13987    13986       -1     
- Misses            29419    29437      +18     
  Partials           1026     1026              
Flag Coverage Δ
unittests 31.46% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@karmada-bot karmada-bot merged commit d6cc843 into karmada-io:release-1.11 Sep 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants