-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove extra slash when constructing member cluster URL if the apiEndpoint of the cluster object ends with a slash #5432
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5432 +/- ##
==========================================
+ Coverage 31.05% 31.16% +0.10%
==========================================
Files 638 640 +2
Lines 44307 44414 +107
==========================================
+ Hits 13760 13842 +82
- Misses 29552 29569 +17
- Partials 995 1003 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign @chaunceyjiang |
… the apiEndpoint of the cluster object ends with a slash. Signed-off-by: 圣朋 <[email protected]>
Hi @spiritNO1, have you tested it yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
This is a great patch! I have already tested it in my local environment. It is working correctly.
kubectl get --raw /apis/cluster.karmada.io/v1alpha1/clusters/*/proxy/apis/apps/v1/namespaces/default/deployments/nginx
/lgtm
/kind bug You need to write the release notes in the description of the PR. |
Yes, modify the cluster.spec.apiEndpoint with / at the end, and not with / at the end. |
done |
How about add the component name in the release note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
/approve
Hi @spiritNO1 would you like to help cherry-pick this patch to the previous release branch?
I created a tracked issue #5455
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5228
Special notes for your reviewer:
Does this PR introduce a user-facing change?: