Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #5227: fix error of when cluster status condition update #5401

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Aug 19, 2024

Cherry pick of #5227 on release-1.10.
#5227: fix error of when cluster status condition update
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`: Fixed the error of cluster status old condition update will overwrite the newest condition.

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the automated-cherry-pick-of-#5227-upstream-release-1.10 branch from 652f5d9 to aeeb2f1 Compare August 19, 2024 12:18
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.29%. Comparing base (cc82274) to head (aeeb2f1).

Files Patch % Lines
...kg/controllers/status/cluster_status_controller.go 67.56% 10 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.10    #5401   +/-   ##
=============================================
  Coverage         53.29%   53.29%           
=============================================
  Files               253      253           
  Lines             20576    20597   +21     
=============================================
+ Hits              10966    10978   +12     
- Misses             8883     8891    +8     
- Partials            727      728    +1     
Flag Coverage Δ
unittests 53.29% <67.56%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@karmada-bot karmada-bot merged commit e77030e into karmada-io:release-1.10 Sep 2, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the automated-cherry-pick-of-#5227-upstream-release-1.10 branch September 25, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants