-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance karmadactl describe command #5392
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5392 +/- ##
==========================================
- Coverage 29.67% 29.66% -0.01%
==========================================
Files 632 632
Lines 43901 43914 +13
==========================================
+ Hits 13027 13029 +2
- Misses 29931 29943 +12
+ Partials 943 942 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0761989
to
ff44d00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some nits, otherwise LGTM.
Signed-off-by: hulizhe <[email protected]>
Signed-off-by: hulizhe <[email protected]>
ff44d00
to
6eae2b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
done~ |
/hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Enhance the
karmadactl describe
command to add the ability to view Karmada control plane resources.Which issue(s) this PR fixes:
Parts of #5249
Special notes for your reviewer:
Does this PR introduce a user-facing change?: