Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance karmadactl describe command #5392

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

hulizhe
Copy link
Contributor

@hulizhe hulizhe commented Aug 18, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Enhance the karmadactl describe command to add the ability to view Karmada control plane resources.

$ karmadactl describe pods --operation-scope members --cluster member1
Name:             nginx
Namespace:        default
Priority:         0
Service Account:  default
Node:             member1-control-plane/172.18.0.3
... ...
$ karmadactl describe pods 
Name:         nginx
Namespace:    default
Priority:     0
Node:         <none>
Labels:       propagationpolicy.karmada.io/permanent-id=d698e260-0eec-4dd7-b571-9c0cedb158f6
Annotations:  propagationpolicy.karmada.io/name: nginx-847459f8b6
              propagationpolicy.karmada.io/namespace: default
Status:       Running
... ...

$ karmadactl describe pods --operation-scope members                  
error: must specify a member cluster

Which issue(s) this PR fixes:
Parts of #5249

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`:  The `describe` command can show details of Karmada resources now.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 18, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 29.66%. Comparing base (1604078) to head (6eae2b9).
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/karmadactl/describe/describe.go 0.00% 21 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5392      +/-   ##
==========================================
- Coverage   29.67%   29.66%   -0.01%     
==========================================
  Files         632      632              
  Lines       43901    43914      +13     
==========================================
+ Hits        13027    13029       +2     
- Misses      29931    29943      +12     
+ Partials      943      942       -1     
Flag Coverage Δ
unittests 29.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

Hi @hulizhe Please rebase this PR since #5254 has been merged and resolve the conflicts.

@hulizhe hulizhe force-pushed the karmadactldescribe branch from 0761989 to ff44d00 Compare August 19, 2024 06:43
@hulizhe
Copy link
Contributor Author

hulizhe commented Aug 19, 2024

Hi @hulizhe Please rebase this PR since #5254 has been merged and resolve the conflicts.

done~

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nits, otherwise LGTM.

pkg/karmadactl/describe/describe.go Outdated Show resolved Hide resolved
pkg/karmadactl/describe/describe.go Outdated Show resolved Hide resolved
@hulizhe hulizhe force-pushed the karmadactldescribe branch from ff44d00 to 6eae2b9 Compare August 19, 2024 07:38
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
@RainbowMango
Copy link
Member

/hold
Please add a release note

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
@hulizhe
Copy link
Contributor Author

hulizhe commented Aug 19, 2024

/hold Please add a release note

done~

@hulizhe
Copy link
Contributor Author

hulizhe commented Aug 19, 2024

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
@karmada-bot karmada-bot merged commit c757122 into karmada-io:master Aug 19, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants