fix pdb collection testing occasional failure

[chaosi-zju]

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

these days, the e2e case [pdb status collection testing] often failed, such as:

https://github.com/karmada-io/karmada/actions/runs/10401933004/job/28805568396?pr=5378
https://github.com/karmada-io/karmada/actions/runs/10401933004/job/28811015421?pr=5378

1. work status of deploment/nginx in member1:

"manifestStatuses": [
      {
        "identifier": {
          "ordinal": 0,
          "group": "apps",
          "version": "v1",
          "kind": "Deployment",
          "resource": "",
          "namespace": "karmadatest-tlftr",
          "name": "poddisruptionbudget-m472d"
        },
        "status": {
          "availableReplicas": 3,
          "generation": 1,
          "observedGeneration": 1,
          "readyReplicas": 3,
          "replicas": 3,
          "resourceTemplateGeneration": 2,
          "updatedReplicas": 3
        },
        "health": "Healthy"
      }
    ]

2. work status of PodDisruptionBudget/nginx in member1:

"manifestStatuses": [
      {
        "identifier": {
          "ordinal": 0,
          "group": "policy",
          "version": "v1",
          "kind": "PodDisruptionBudget",
          "resource": "",
          "namespace": "karmadatest-tlftr",
          "name": "poddisruptionbudget-m472d"
        },
        "status": {
          "currentHealthy": 6,
          "desiredHealthy": 3,
          "disruptionsAllowed": 3,
          "expectedPods": 6
        },
        "health": "Healthy"
      }

so, the pdb selected more than 3 pods by app:nginx, it has selected another 3 pods created by other e2e cases.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[chaosi-zju]

@zhzhuang-zju @XiShanYongYe-Chang

[zhzhuang-zju]

/assign

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.35%. Comparing base (cd99897) to head (e7e06ce).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5382      +/-   ##
==========================================
- Coverage   29.35%   29.35%   -0.01%     
==========================================
  Files         632      632              
  Lines       43862    43862              
==========================================
- Hits        12877    12874       -3     
- Misses      30050    30053       +3     
  Partials      935      935              

Flag	Coverage Δ
unittests	29.35% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhzhuang-zju]

thanks, looks like the issue is a conflict with other e2e tests again
others LGMT

[XiShanYongYe-Chang]

Can you explain a little bit why the occasional error occurs?

[chaosi-zju]

Can you explain a little bit why the occasional error occurs?

done

[chaosi-zju]

bug found, it should be:

Suggested change

	deployment.SetLabels(matchLabels)
	deployment.Spec.Selector.MatchLabels = matchLabels
	deployment.Spec.Template.Labels = matchLabels

[chaosi-zju]

/retest

[chaosi-zju]

It is s ready to move forward~

[zhzhuang-zju]

/lgtm
ask @XiShanYongYe-Chang to take another look

[XiShanYongYe-Chang]

Thanks~
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment